Add bits as an optional feature for bitvec #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark for 4a76c64Click to view benchmark
|
Benchmark for 8947ee1Click to view benchmark
|
Benchmark for 755ed48Click to view benchmark
|
wcampbell0x2a
force-pushed
the
add-bits-feature
branch
from
2913a9f to
6b6276e
Compare
wcampbell0x2a
changed the title
Benchmark for 6bea42bClick to view benchmark
|
|
I think the warning is fair, although, what needs to be done to have more assurance and remove that warning? |
wcampbell0x2a
force-pushed
the
439-improve-read-all-perf
branch
from
03ff770 to
312cbad
Compare
wcampbell0x2a
force-pushed
the
add-bits-feature
branch
from
6b6276e to
f3950ca
Compare
I updated this code to behave with running |
| @@ -22,6 +22,8 @@ jobs: | |||
| - run: cargo test --all | |||
| # run examples | |||
| - run: cargo run --example 2>&1 | grep -P ' ' | awk '{print $1}' | xargs -i cargo run --example {} | |||
| # test with no bits feature (don't test docs) | |||
wcampbell0x2a
dismissed
sharksforarms’s stale review
The base branch was changed.
wcampbell0x2a
force-pushed
the
add-bits-feature
branch
4 times, most recently
from
6feb4f3 to
75b4894
Compare
wcampbell0x2a
force-pushed
the
add-bits-feature
branch
2 times, most recently
from
569346f to
912a993
Compare
Benchmark for c7c2498Click to view benchmark
|
Benchmark for c7c2498Click to view benchmark
|
Benchmark for 8082ea9Click to view benchmark
|
Benchmark for 8082ea9Click to view benchmark
|
wcampbell0x2a
commented
Sep 4, 2024
.github/workflows/pull_request.yml
Outdated
| with: | ||
| branchName: ${{ github.base_ref }} | ||
| token: ${{ secrets.GITHUB_TOKEN }} | ||
| defaultFeatures: false |
There was a problem hiding this comment.
This option doesn't seem to be adding --no-default-features like it should :/
idk javascript: /~https://github.com/boa-dev/criterion-compare-action/blob/59f4d964c5f19d7f13d36f5c0944b18ce6652cb0/main.js#L37
There was a problem hiding this comment.
Maybe I fixed it, i'll try out my test version here...
There was a problem hiding this comment.
Didn't fix it, guess I won't become a js dev anytime soon 😆
wcampbell0x2a
force-pushed
the
add-bits-feature
branch
2 times, most recently
from
a1d31d0 to
1c7b605
Compare
Benchmark for 91baeb0Click to view benchmark
|
Benchmark for 91baeb0Click to view benchmark
|
An error occurred while trying to automatically change base from
fix-ci
to
master
September 4, 2024 12:28
wcampbell0x2a
force-pushed
the
add-bits-feature
branch
from
1c7b605 to
2dce769
Compare
Benchmark for 2f63882Click to view benchmark
|
wcampbell0x2a
force-pushed
the
add-bits-feature
branch
2 times, most recently
from
6fe89e4 to
3af1acf
Compare
Benchmark for 920345eClick to view benchmark
|
Benchmark for f998f16Click to view benchmark
|
wcampbell0x2a
force-pushed
the
add-bits-feature
branch
from
3af1acf to
a9ebc26
Compare
Benchmark for 45a4aeaClick to view benchmark
|
* Use bits feature to correctly disallow bit related attributes from being used
wcampbell0x2a
force-pushed
the
add-bits-feature
branch
from
a9ebc26 to
32b6779
Compare
Benchmark for 07f5db4Click to view benchmark
|
sharksforarms
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is like the final boss of all my performance work. I try to explain the "no warranty and testing are given for the disable of this feature", while still implementing enough to make this useful in the case of "I want perf to matter".
bench: wcampbell0x2a/deku-bench#24